Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(wgt): add torch-rpc fix dockerfile and add new rpc deploy CI-… #606

Closed
wants to merge 9 commits into from
Closed

feature(wgt): add torch-rpc fix dockerfile and add new rpc deploy CI-… #606

wants to merge 9 commits into from

Conversation

SolenoidWGT
Copy link
Collaborator

@SolenoidWGT SolenoidWGT commented Mar 9, 2023 •
edited
Loading

Description

PR for torch-rpc imgae build CI-action.

Related Issue

torchrpc: #562

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@SolenoidWGT SolenoidWGT closed this Mar 9, 2023
@SolenoidWGT SolenoidWGT reopened this Mar 9, 2023
@PaParaZz1 PaParaZz1 added the docker Add or update dockerfile label Mar 10, 2023
PaParaZz1
PaParaZz1 requested changes Mar 10, 2023
View reviewed changes
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@SolenoidWGT SolenoidWGT force-pushed the p2p-rpc-dockerfile branch 3 times, most recently from 767c141 to 7d54f6c Compare March 15, 2023 06:38
@codecov
Copy link

codecov bot commented Mar 15, 2023 •
edited
Loading

Codecov Report

Merging #606 (767c141) into main (c30818a) will decrease coverage by 1.51%.
The diff coverage is 50.57%.

❗ Current head 767c141 differs from pull request most recent head b55d2f5. Consider uploading reports for the commit b55d2f5 to get more accurate results

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   84.81%   83.30%   -1.51%     
==========================================
  Files         555      569      +14     
  Lines       44673    46737    +2064     
==========================================
+ Hits        37889    38936    +1047     
- Misses       6784     7801    +1017
Flag Coverage Δ
unittests 83.30% <50.57%> (-1.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/bonus/__init__.py 0.00% <0.00%> (ø)
ding/bonus/config.py 0.00% <0.00%> (ø)
ding/bonus/model.py 0.00% <0.00%> (ø)
ding/bonus/ppof.py 0.00% <0.00%> (ø)
ding/config/__init__.py 100.00% <ø> (ø)
ding/data/buffer/deque_buffer_wrapper.py 60.00% <ø> (ø)
...test_serial_entry_preference_based_irl_onpolicy.py 93.54% <ø> (-0.21%) ⬇️
ding/model/common/__init__.py 100.00% <ø> (ø)
ding/reward_model/gail_irl_model.py 100.00% <ø> (ø)
ding/reward_model/pdeil_irl_model.py 86.31% <ø> (ø)
... and 83 more

... and 220 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Merge branch 'p2p-rpc-dockerfile' of https://github.com/SolenoidWGT/D…
b55d2f5 
…I-engine into p2p-rpc-dockerfile

Conflicts:
	docker/Dockerfile.rpc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaParaZz1 PaParaZz1 PaParaZz1 requested changes

Assignees
No one assigned
Labels
docker Add or update dockerfile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SolenoidWGT @PaParaZz1